Skip to content

docs(python-uv): consolidate DESIGN.md after the uv fixes - #971

Merged
bnusunny merged 4 commits into
aws:developfrom
bnusunny:docs/python-uv-design-consolidation
Nov 18, 2026
Merged

bnusunny merged 4 commits into
aws:developfrom
bnusunny:docs/python-uv-design-consolidation

Conversation

@bnusunny

Copy link
Copy Markdown
Contributor

Issue #, if available: #839

Description of changes

Docs only. Brings aws_lambda_builders/workflows/python_uv/DESIGN.md in line with the merged python_uv fixes:

Description of how you validated changes

Checked the text against aws_lambda_builders/workflows/python_uv/*.py on develop. make lint and make black-check pass.

Checklist

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@bnusunny
bnusunny requested a review from a team as a code owner November 17, 2026 23:13
UvConfig accepts compile_bytecode but never passes it to uv, so the
example implied a setting the build does not apply.
…esign-consolidation

# Conflicts:
#	aws_lambda_builders/workflows/python_uv/DESIGN.md
@bnusunny bnusunny mentioned this pull request Nov 18, 2026
1 task done

@vicheey vicheey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pulling this together, it reads much closer to the code now.

  • Lines 148-149: -e ../shared resolves from the manifest directory, but an editable requirement installs only a .pth pointing at the build machine's path, so the package isn't in the artifact. Could the example use a non-editable path like ../shared instead? That also keeps it consistent with "nothing is installed editable" further down.
  • Line 110: the workflow also auto-detects when the given manifest path doesn't exist (workflow.py), so maybe "Without one, or when the given path doesn't exist, ...".
  • Nit (optional): the new "Stale locks" paragraph and the "uv warnings" section repeat lines 122-124 and 260-262. While you're in the file, the docstring's "when present in the same directory" (62-63) and "Minimum UV version: 0.1.0" (367) are also stale.

@bnusunny
bnusunny enabled auto-merge (squash) November 18, 2026 23:17
@bnusunny
bnusunny merged commit 471e5d7 into aws:develop Nov 18, 2026
124 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants